fix(DB/Creature): add Power Spark movement to Power Spark (1)#25234
fix(DB/Creature): add Power Spark movement to Power Spark (1)#25234sogladev wants to merge 1 commit intoazerothcore:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the world DB to fix the 25m “Power Spark (1)” (creature entry 32187) falling mid-air by applying a movement template intended to disable gravity, matching the 10m Power Spark behavior.
Changes:
- Adds a
creature_template_movementrecord for creature32187. - Sets the movement template to enable
Flight(DisableGravity) for32187. - Removes any pre-existing movement template row for
32187before inserting the new one.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| INSERT INTO `creature_template_movement` (`CreatureId`, `Ground`, `Swim`, `Flight`, `Rooted`, `Chase`, `Random`, `InteractionPauseTimer`) VALUES | ||
| (32187, 0, 0, 1, 0, 0, 0, 0); |
There was a problem hiding this comment.
The inserted creature_template_movement row sets Ground to 0 (CreatureGroundMovementType::None) and InteractionPauseTimer to 0, which is not equivalent to the 10m Power Spark template (30084) you referenced (it has Ground/InteractionPauseTimer as NULL). This may unintentionally disable any ground movement fallback and override the server default interaction pause timer. Consider only setting the needed column(s) (e.g., Flight = 1 / DisableGravity) and leaving other fields NULL to preserve defaults and match the 10m behavior more closely.
| INSERT INTO `creature_template_movement` (`CreatureId`, `Ground`, `Swim`, `Flight`, `Rooted`, `Chase`, `Random`, `InteractionPauseTimer`) VALUES | |
| (32187, 0, 0, 1, 0, 0, 0, 0); | |
| INSERT INTO `creature_template_movement` (`CreatureId`, `Flight`) VALUES | |
| (32187, 1); |
Changes Proposed:
This PR proposes changes to:
Fix 25m version of Power Spark "falling" mid-air. Copied movement from the 10m Power Spark.
AI-assisted Pull Requests
Important
While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.
Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.