Skip to content

fix(DB/Creature): add Power Spark movement to Power Spark (1)#25234

Open
sogladev wants to merge 1 commit intoazerothcore:masterfrom
sogladev:fix-db-malygos-spark-gravity
Open

fix(DB/Creature): add Power Spark movement to Power Spark (1)#25234
sogladev wants to merge 1 commit intoazerothcore:masterfrom
sogladev:fix-db-malygos-spark-gravity

Conversation

@sogladev
Copy link
Copy Markdown
Member

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Fix 25m version of Power Spark "falling" mid-air. Copied movement from the 10m Power Spark.

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

  • AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Copilot AI review requested due to automatic review settings March 25, 2026 20:08
@github-actions github-actions bot added the DB related to the SQL database label Mar 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the world DB to fix the 25m “Power Spark (1)” (creature entry 32187) falling mid-air by applying a movement template intended to disable gravity, matching the 10m Power Spark behavior.

Changes:

  • Adds a creature_template_movement record for creature 32187.
  • Sets the movement template to enable Flight (DisableGravity) for 32187.
  • Removes any pre-existing movement template row for 32187 before inserting the new one.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3 to +4
INSERT INTO `creature_template_movement` (`CreatureId`, `Ground`, `Swim`, `Flight`, `Rooted`, `Chase`, `Random`, `InteractionPauseTimer`) VALUES
(32187, 0, 0, 1, 0, 0, 0, 0);
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inserted creature_template_movement row sets Ground to 0 (CreatureGroundMovementType::None) and InteractionPauseTimer to 0, which is not equivalent to the 10m Power Spark template (30084) you referenced (it has Ground/InteractionPauseTimer as NULL). This may unintentionally disable any ground movement fallback and override the server default interaction pause timer. Consider only setting the needed column(s) (e.g., Flight = 1 / DisableGravity) and leaving other fields NULL to preserve defaults and match the 10m behavior more closely.

Suggested change
INSERT INTO `creature_template_movement` (`CreatureId`, `Ground`, `Swim`, `Flight`, `Rooted`, `Chase`, `Random`, `InteractionPauseTimer`) VALUES
(32187, 0, 0, 1, 0, 0, 0, 0);
INSERT INTO `creature_template_movement` (`CreatureId`, `Flight`) VALUES
(32187, 1);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB related to the SQL database Ready to be Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants