Open
Conversation
✅ Deploy Preview for aya-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tamird
reviewed
Dec 31, 2025
TheMagicNacho
force-pushed
the
update-function-names
branch
from
19c9b8f to
f6fcef2
Compare
tamird
reviewed
Dec 31, 2025
| #[xdp] | ||
| pub fn xdp_firewall(ctx: XdpContext) -> u32 { | ||
| match try_xdp_firewall(ctx) { | ||
| pub fn xdp_log(ctx: XdpContext) -> u32 { |
Member
There was a problem hiding this comment.
I don't understand this change either. The userspace side expects the old name:
book/examples/xdp-log/xdp-log/src/main.rs
Line 48 in 2bcbd1f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing that the the tutorials were coppied from firewall to log, but some of the function names were not refactored in the process. This resulted in a bug where the tutorial applications would not run, but
cargo checkwould pass.This fix makes the tutorial function names match accross BPF and user-land; allowing the tutorial to run without any modifications.
This change is