BufferOverflow fix + HTTP Header size max#10
Open
User65k wants to merge 1 commit intoaxiomatic-systems:masterfrom
Open
BufferOverflow fix + HTTP Header size max#10User65k wants to merge 1 commit intoaxiomatic-systems:masterfrom
User65k wants to merge 1 commit intoaxiomatic-systems:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the following changes fix a buffer overflow in String.append and set an upper limit to the size of a single HTTP-Header in order to improve robustness.
The buffer overflow results if there is an overflow in NPT_Size (32bit int) as the Reserve function does not update if the new size is smaller. So data is written in unused mem