Add support for Video sample description extensions (COLR / GAMA / PASP / FIEL)#694
Open
Shootfast wants to merge 3 commits intoaxiomatic-systems:masterfrom
Open
Conversation
These atoms are part of the Video Sample Description Extensions, and provide additional information and/or display hints for decompressors.
By explicitly handling these video codecs as VisualSampleEntry(s), we are able to decend past their initial outer atom and access any extension atoms that may be present.
Contributor
|
Thanks for this, @Shootfast! Works for me. Let's merge it! |
Contributor
|
I'll merge the PR shortly (I need to update some of the platform-specific project/build files to ensure that the new .cpp files are compiles and linked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces support for handling
colr,gama,pasp, andfielatoms.These atoms are part of the Video Sample Description Extensions - documented here:
https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html#//apple_ref/doc/uid/TP40000939-CH205-124374
To access these atoms, additional handling of ProRes, mjpeg, and DNxHR /DNxHD codecs was added. Other codecs may need similar treatment, but these are the ones I most frequently encounter.
This pull request satisfies my very ancient feature request #167 .
The new functionality was tested via the following workflow:
I've tried to adhere to the style of the surrounding library, but please let me know if I should change anything.