Skip to content

Fix heap buffer overflow in AP4_Ac4Parser and AP4_Dac4Atom#1062

Open
MingxinChen wants to merge 1 commit into
axiomatic-systems:masterfrom
DolbyLaboratories:fix_ac4_heap_buffer_overflow
Open

Fix heap buffer overflow in AP4_Ac4Parser and AP4_Dac4Atom#1062
MingxinChen wants to merge 1 commit into
axiomatic-systems:masterfrom
DolbyLaboratories:fix_ac4_heap_buffer_overflow

Conversation

@MingxinChen
Copy link
Copy Markdown
Contributor

Changes:

  • Added GetBitsAvailable() method to AP4_BitReader to expose the number of bits remaining in the buffer
  • Added bounds checking with appropriate error handling to prevent out-of-bounds reads when parsing malformed/maliciously crafted MP4 files

Related Issues: #1060, #1059, #1058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant