Allow beforeSigning event to modify typ header property#388
Merged
poveden merged 2 commits intoaxa-group:masterfrom Jan 26, 2026
Merged
Conversation
nulltoken
changed the title
typ key header
nulltoken
changed the title
typ key headertyp header property
Contributor
|
@AndreasNill LGTM. Thanks a lot! @poveden How do you like it? |
nulltoken
reviewed
Jan 23, 2026
nulltoken
requested changes
Jan 24, 2026
Contributor
nulltoken
left a comment
nulltoken
left a comment
There was a problem hiding this comment.
@AndreasNill Could you please take a look at the test related comment?
nulltoken
approved these changes
Jan 24, 2026
poveden
approved these changes
Jan 26, 2026
Contributor
|
@AndreasNill Released through v8.2.1 Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #387
PR Checklist
npm testlocally and all tests are passing.PR Description
As proposed I moved the spread operator behind the
keyargument. I didn't move it to the last position as thealgheader must match the algorithm of the signing key. I updated thebeforeSigningtests accordingly.