add missing dev dependencies so we can run the test suite#46
Open
chrislewis wants to merge 2 commits intoawslabs:masterfrom
Open
add missing dev dependencies so we can run the test suite#46chrislewis wants to merge 2 commits intoawslabs:masterfrom
chrislewis wants to merge 2 commits intoawslabs:masterfrom
Conversation
This was referenced Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a modest test suite for the
nodeimplementation atkinesis-aggregation/node/node_modules/aws-kinesis-agg/test. However, none of the tests can be run as they require modules that are not accounted for in the overall module's (dev) dependencies. This PR adds those so the individual tests can be run.This also fixes the broken test
kinesis-aggregation/node/node_modules/aws-kinesis-agg/test/testRawAggregation.js