Skip to content

Comments

fix: headerBasedAuth not updating the headers with new values#667

Open
chrisharrison wants to merge 2 commits intoawslabs:masterfrom
chrisharrison:master
Open

fix: headerBasedAuth not updating the headers with new values#667
chrisharrison wants to merge 2 commits intoawslabs:masterfrom
chrisharrison:master

Conversation

@chrisharrison
Copy link

@chrisharrison chrisharrison commented Aug 20, 2021

Issue #, if available:

#666

Description of changes:

Allows the headerBasedAuth function to actually update the headers with the new value.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chrisharrison
Copy link
Author

This fixes #666

@chrisharrison
Copy link
Author

This should be applied as a hotfix to aws-appsync-auth-link version 2.0.5

@ronnyroeller
Copy link

ronnyroeller commented Aug 28, 2023

The Amplify docs still advises to use this repo when using Apollo Client: https://docs.amplify.aws/lib/graphqlapi/upgrade-guide/q/platform/js/#option-2-upgrade-to-apollo-client-with-appsync-links

Wouldn't it make sense to merged this PR then? Or is there by now an alternative advised approach of how to use Apollo Client with AppSync?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants