fix: emit KiroChatMessageEvent to STE for every GenerateAssistantResponse request#2594
Draft
fix: emit KiroChatMessageEvent to STE for every GenerateAssistantResponse request#2594
Conversation
Will-ShaoHua
approved these changes
Jan 21, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
==========================================
+ Coverage 60.60% 60.65% +0.04%
==========================================
Files 278 278
Lines 65099 65152 +53
Branches 4145 4153 +8
==========================================
+ Hits 39451 39515 +64
+ Misses 25564 25553 -11
Partials 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…d by agenticCodingMode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Product needs metrics for enterprises. Therefore, backend has added a new
KiroChatMessageEventSTE event which the client should send for everyGenerateAssistantResponserequest.Solution
We will now also send
KiroChatMessageEventevery time we send a request toGenerateAssistantResponseTesting
Confirmed that the metric shape follows smithy model provided by backend team
Tested in RTS alpha
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.