doc: search only returns results from selected version and fix latest version#9033
Merged
joshuakguo merged 2 commits intoaws:mainfrom Mar 27, 2026
Merged
doc: search only returns results from selected version and fix latest version#9033joshuakguo merged 2 commits intoaws:mainfrom
joshuakguo merged 2 commits intoaws:mainfrom
Conversation
Contributor
|
Preview deployment ready! Preview URL: https://pr-9033.d18coufmbnnaag.amplifyapp.com Built from commit |
joshuakguo
changed the title
joshuakguo
force-pushed
the
website-search-fix
branch
2 times, most recently
from
0bcec5e to
f90e899
Compare
joshuakguo
force-pushed
the
website-search-fix
branch
from
f90e899 to
32ac91b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3172 and #8349
Description
makes the website search only return results of the current version
also makes the search better since we're returning more different entries rather than just the same entry from different versions, for example - the "settings" search from the issue is more helpful now
note: needed to pull in https://github.com/google/docsy/blob/main/assets/js/offline-search.js and edit it but the search.js that's already there is also the same so unsure if additional attributions are needed
How was this change tested?
tested locally when i deployed the website
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.