Feature - Amazon Q Code Transform Update#648
Merged
awschristou merged 1 commit intoaws:mainfrom Dec 11, 2023
Merged
Conversation
- Update allowedValues for definition to remove spaces from values - Update Typescript to NOT replace spaces in allowedValues with underscores
awschristou
approved these changes
Dec 11, 2023
justinmk3
reviewed
Dec 11, 2023
| const modifiedVal = typeof v === "string" ? v.replace(/\s/g, "_") : v; | ||
| return `'${modifiedVal}'` | ||
| }).join(' | '), | ||
| type: m.allowedValues.map(v => `'${v}'`).join(' | '), |
Contributor
There was a problem hiding this comment.
can a small test be added for this https://github.com/aws/aws-toolkit-common/blob/main/telemetry/vscode/test/generator.test.ts
Edit: oh I missed #641
There was a problem hiding this comment.
Is it possible that allowedValues is undefined?
This was referenced Dec 11, 2023
yuwuc
reviewed
Dec 12, 2023
Comment on lines
+1044
to
+1051
| "NoPom", | ||
| "NoJavaProject", | ||
| "MixedLanguages", | ||
| "UnsupportedJavaVersion", | ||
| "NonMavenProject", | ||
| "EmptyProject", | ||
| "NonSsoLogin", | ||
| "RemoteRunProject" |
There was a problem hiding this comment.
Do we map these values to a proper error message?
| const modifiedVal = typeof v === "string" ? v.replace(/\s/g, "_") : v; | ||
| return `'${modifiedVal}'` | ||
| }).join(' | '), | ||
| type: m.allowedValues.map(v => `'${v}'`).join(' | '), |
There was a problem hiding this comment.
Is it possible that allowedValues is undefined?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sub PR for -> https://github.com/aws/aws-toolkit-common/pull/641/files
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.