aws/transport/http: set TLS curve preferences - #3454
Open
sverma98015-commits wants to merge 1 commit into
Open
Conversation
Collaborator
|
Is there motivation for this beyond clarity? How were these values chosen? What potential impact does this have across the 400+ AWS services supported by this SDK today? I am concerned about changing this without more context, even with that I would have pretty significant backwards-compatibility concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the default HTTP transport configuration to explicitly set TLS curve preferences.
Changes
Added TLS curve preferences to
tls.ConfigindefaultHTTPTransport:Ensures consistent elliptic curve selection for TLS connections.
Added unit test to validate:
Motivation
Improves TLS configuration clarity and ensures predictable elliptic curve usage in secure connections.
Testing
go test ./aws/transport/httpNotes
No changes to generated code or service models.