Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 95.80% 92.62% -3.18%
==========================================
Files 61 71 +10
Lines 8143 10053 +1910
Branches 0 10053 +10053
==========================================
+ Hits 7801 9312 +1511
- Misses 342 450 +108
- Partials 0 291 +291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1328ba1 to
fa8ef24
Compare
dd4f2ac to
ee6e3eb
Compare
ee6e3eb to
ed553cb
Compare
WillChilds-Klein
previously approved these changes
Feb 12, 2026
WillChilds-Klein
previously approved these changes
Feb 16, 2026
9ab93a0 to
eb428b9
Compare
WillChilds-Klein
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR unifies the build scripts for
aws-lc-sysandaws-lc-fips-sysinto a single shared./builderdirectory. Both sys-cratebuilderdirectories are now symlinks to../builder, eliminating significant code duplication between the two crates.Call-outs
aws-lc-sys: This will not used byaws-lc-rs, butaws-lc-sysnow supports a "fips" feature that triggers a FIPS-module build of its source.bindgendependency:bindgenis now a standard build dependency foraws-lc-fips-sys. (Like withaws-lc-sys, it's no longer conditionally included based on target platform.)rust_wrapperfrom FIPS: The FIPS build no longer produces a separaterust_wrapperlibrary; helper functions are now implemented in pure RustEnvGuard: RAII helper for temporary environment variable modifications during builds.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.