Skip to content

Unify sys-crate build scripts#995

Open
justsmth wants to merge 9 commits intoaws:mainfrom
justsmth:unify-build-scripts
Open

Unify sys-crate build scripts#995
justsmth wants to merge 9 commits intoaws:mainfrom
justsmth:unify-build-scripts

Conversation

@justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 8, 2026

Description

This PR unifies the build scripts for aws-lc-sys and aws-lc-fips-sys into a single shared ./builder directory. Both sys-crate builder directories are now symlinks to ../builder, eliminating significant code duplication between the two crates.

Call-outs

  • fips feature for aws-lc-sys: This will not used by aws-lc-rs, but aws-lc-sys now supports a "fips" feature that triggers a FIPS-module build of its source.
  • Simplified bindgen dependency: bindgen is now a standard build dependency for aws-lc-fips-sys. (Like with aws-lc-sys, it's no longer conditionally included based on target platform.)
  • Removed rust_wrapper from FIPS: The FIPS build no longer produces a separate rust_wrapper library; helper functions are now implemented in pure Rust
  • Added EnvGuard: RAII helper for temporary environment variable modifications during builds.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.62%. Comparing base (c358484) to head (eb428b9).
⚠️ Report is 338 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   95.80%   92.62%   -3.18%     
==========================================
  Files          61       71      +10     
  Lines        8143    10053    +1910     
  Branches        0    10053   +10053     
==========================================
+ Hits         7801     9312    +1511     
- Misses        342      450     +108     
- Partials        0      291     +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the unify-build-scripts branch 17 times, most recently from 1328ba1 to fa8ef24 Compare January 9, 2026 18:36
@justsmth justsmth force-pushed the unify-build-scripts branch 4 times, most recently from dd4f2ac to ee6e3eb Compare February 12, 2026 17:44
@justsmth justsmth changed the title [DRAFT] Unify sys-crate build scripts Unify sys-crate build scripts Feb 12, 2026
@justsmth justsmth force-pushed the unify-build-scripts branch from ee6e3eb to ed553cb Compare February 12, 2026 18:53
@justsmth justsmth marked this pull request as ready for review February 12, 2026 18:53
@justsmth justsmth requested a review from a team as a code owner February 12, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants