Skip to content

Check cranelift when using the cargo-clif executable#1047

Merged
justsmth merged 2 commits intoaws:mainfrom
frederikhors:patch-1
Feb 18, 2026
Merged

Check cranelift when using the cargo-clif executable#1047
justsmth merged 2 commits intoaws:mainfrom
frederikhors:patch-1

Conversation

@frederikhors
Copy link
Contributor

@frederikhors frederikhors commented Feb 18, 2026

Fixes #537 (comment).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@frederikhors frederikhors requested a review from a team as a code owner February 18, 2026 15:35
@bjorn3
Copy link

bjorn3 commented Feb 18, 2026

This may be a bit too loose. It would also match for example RUSTFLAGS="--cfg use_cranelift_for_wasm" or something like that. Not that I could find any actual cases on github where that happens though.

@justsmth
Copy link
Contributor

From my testing, I believe most platforms were fine linking using the "no u1" (terrible name) bindings, even if it's not required. So it might be ok for this to be overly broad in catching "cranelift".

Would this also catch for consumers using codegen-backend = "cranelift" in their .cargo/config.toml?

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.62%. Comparing base (c358484) to head (a466e16).
⚠️ Report is 337 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   95.80%   92.62%   -3.18%     
==========================================
  Files          61       71      +10     
  Lines        8143    10053    +1910     
  Branches        0    10053   +10053     
==========================================
+ Hits         7801     9312    +1511     
- Misses        342      450     +108     
- Partials        0      291     +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frederikhors
Copy link
Contributor Author

Would this also catch for consumers using codegen-backend = "cranelift" in their .cargo/config.toml?

I think this already works in the actual main branch code.

justsmth
justsmth previously approved these changes Feb 18, 2026
@frederikhors
Copy link
Contributor Author

I can't wait to try it!

@justsmth
Copy link
Contributor

Hi @frederikhors -- We have a CI job that verifies the following text appears in the PR description:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

If you agree, would you update the PR description with this text?

@frederikhors
Copy link
Contributor Author

frederikhors commented Feb 18, 2026

Do you mean in the first post? Done.

@justsmth justsmth merged commit b6b1558 into aws:main Feb 18, 2026
375 checks passed
@frederikhors frederikhors deleted the patch-1 branch February 18, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build w/ rustc_codegen_cranelift compiler backend

5 participants