Check cranelift when using the cargo-clif executable#1047
Conversation
|
This may be a bit too loose. It would also match for example |
|
From my testing, I believe most platforms were fine linking using the "no u1" (terrible name) bindings, even if it's not required. So it might be ok for this to be overly broad in catching "cranelift". Would this also catch for consumers using |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
==========================================
- Coverage 95.80% 92.62% -3.18%
==========================================
Files 61 71 +10
Lines 8143 10053 +1910
Branches 0 10053 +10053
==========================================
+ Hits 7801 9312 +1511
- Misses 342 450 +108
- Partials 0 291 +291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think this already works in the actual main branch code. |
|
I can't wait to try it! |
|
Hi @frederikhors -- We have a CI job that verifies the following text appears in the PR description:
If you agree, would you update the PR description with this text? |
|
Do you mean in the first post? Done. |
Fixes #537 (comment).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.