Skip to content

docs(ec2): clarify RouterType.GATEWAY supports Virtual Private Gateway#38358

Open
wasim-builds wants to merge 2 commits into
aws:mainfrom
wasim-builds:fix/ec2-routertype-gateway-doc
Open

docs(ec2): clarify RouterType.GATEWAY supports Virtual Private Gateway#38358
wasim-builds wants to merge 2 commits into
aws:mainfrom
wasim-builds:fix/ec2-routertype-gateway-doc

Conversation

@wasim-builds

@wasim-builds wasim-builds commented Jul 21, 2026

Copy link
Copy Markdown

Fixes #37632.

The doc comment on RouterType.GATEWAY only mentioned "Internet Gateway", but the underlying CloudFormation GatewayId property also accepts a Virtual Private Gateway ID. This updates the comment to reflect that it supports both.

@github-actions github-actions Bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 21, 2026
@aws-cdk-automation
aws-cdk-automation requested a review from a team July 21, 2026 15:36
@wasim-builds
wasim-builds force-pushed the fix/ec2-routertype-gateway-doc branch from 88c20a3 to 1272cc3 Compare July 21, 2026 16:19
@aws-cdk-automation aws-cdk-automation mentioned this pull request Jul 22, 2026
Open
@wasim-builds
wasim-builds force-pushed the fix/ec2-routertype-gateway-doc branch from 1272cc3 to 3e4c5cd Compare July 23, 2026 15:03
@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

⚠️ The sha of the head commit of this PR conflicts with #38357. Mergify cannot evaluate rules on this PR. Once #38357 is merged or closed, Mergify will resume processing this PR. ⚠️

@wasim-builds

wasim-builds commented Jul 23, 2026

Copy link
Copy Markdown
Author

Rebased onto latest upstream/main. No other changes.

@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-ec2): RouterType.GATEWAY comment is misleading - it also supports Virtual Private Gateway

2 participants

@wasim-builds @aws-cdk-automation