feat(rds): add name property to option group#36319
Conversation
|
|
||||||||||||||
|
|
||||||||||||||
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| * | ||
| * @default - a CDK generated name | ||
| */ | ||
| readonly name?: string; |
There was a problem hiding this comment.
Our design guidelines is to follow the service name documentation which is optionGroupName also it will be aligned with other resources(s3.Bucket or lambda.Function)
Can we change it to optionGroupName?
There was a problem hiding this comment.
I Change it to optoinGroupName
Pull request has been modified.
2593e28 to
1a03285
Compare
|
@gasolima Thank you for the review. I’ve addressed the review comments. While making the fixes, the PR’s CI failed, so I merged the changes from main. As a result, it now shows “This branch has conflicts that must be resolved.” Should I revert the merge of the changes from main? |
I fixed the merge conflicts part, now the build succeeded which is a good sign once the integration test succeed will merge the PR. Thanks for your contribution! |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 32fcbbb This pull request spent 6 hours 44 minutes 12 seconds in the queue, including 6 hours 44 minutes 2 seconds running CI. Required conditions to merge
|
|
Comments on closed issues and PRs are hard for our team to see. |
Issue
Closes #35720 .
Reason for this change
This change fixes an issue in the RDS OptionGroup L2 construct where some parameter settings were not correctly reflected in CloudFormation.
Description of changes
Describe any new or updated permissions being added
No extra permissions needed
Description of how you validated changes
Added a unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license