Skip to content

feat(rds): add name property to option group#36319

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
tnb-git:issue-35720
Jan 5, 2026
Merged

feat(rds): add name property to option group#36319
mergify[bot] merged 6 commits intoaws:mainfrom
tnb-git:issue-35720

Conversation

@tnb-git
Copy link
Copy Markdown
Contributor

@tnb-git tnb-git commented Dec 6, 2025

Issue

Closes #35720 .

Reason for this change

This change fixes an issue in the RDS OptionGroup L2 construct where some parameter settings were not correctly reflected in CloudFormation.

Description of changes

  • Added support for additional parameters in the OptionGroup L2 construct.
  • Updated the integration test (integ.option-group.ts)
  • No impact on existing default settings.

Describe any new or updated permissions being added

No extra permissions needed

Description of how you validated changes

Added a unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 6, 2025 04:57
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Dec 6, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 6, 2025

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results48 ran48 passed
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 6, 2025

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates48 ran48 passed
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 6, 2025 06:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 6, 2025
*
* @default - a CDK generated name
*/
readonly name?: string;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our design guidelines is to follow the service name documentation which is optionGroupName also it will be aligned with other resources(s3.Bucket or lambda.Function)

Can we change it to optionGroupName?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Change it to optoinGroupName

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 18, 2025
@mergify mergify bot dismissed gasolima’s stale review December 20, 2025 01:15

Pull request has been modified.

@tnb-git tnb-git force-pushed the issue-35720 branch 2 times, most recently from 2593e28 to 1a03285 Compare December 21, 2025 11:32
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 21, 2025
@tnb-git
Copy link
Copy Markdown
Contributor Author

tnb-git commented Dec 23, 2025

@gasolima Thank you for the review. I’ve addressed the review comments. While making the fixes, the PR’s CI failed, so I merged the changes from main. As a result, it now shows “This branch has conflicts that must be resolved.” Should I revert the merge of the changes from main?

@gasolima gasolima added the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Jan 5, 2026
@gasolima gasolima temporarily deployed to deployment-integ-test January 5, 2026 16:05 — with GitHub Actions Inactive
@gasolima
Copy link
Copy Markdown
Contributor

gasolima commented Jan 5, 2026

@gasolima Thank you for the review. I’ve addressed the review comments. While making the fixes, the PR’s CI failed, so I merged the changes from main. As a result, it now shows “This branch has conflicts that must be resolved.” Should I revert the merge of the changes from main?

I fixed the merge conflicts part, now the build succeeded which is a good sign once the integration test succeed will merge the PR. Thanks for your contribution!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 5, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot temporarily deployed to deployment-integ-test January 5, 2026 16:43 Inactive
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 5, 2026

Merge Queue Status

✅ The pull request has been merged at 32fcbbb

This pull request spent 6 hours 44 minutes 12 seconds in the queue, including 6 hours 44 minutes 2 seconds running CI.
The checks were run in-place.

Required conditions to merge

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 5, 2026
@mergify mergify bot merged commit 708d0ac into aws:main Jan 5, 2026
29 of 30 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 5, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-rds: Add option group name parameter

3 participants