Open
Conversation
karenc-bq
force-pushed
the
test/hibernate
branch
14 times, most recently
from
5741bfb to
16d3f05
Compare
sergiyvamz
reviewed
Mar 20, 2026
| if (jvm == TargetJvm.OPENJDK24 && config.noOpenJdk24) { | ||
| continue; | ||
| } | ||
| if (jvm != TargetJvm.OPENJDK24 && config.testHibernateOnly) { |
Contributor
There was a problem hiding this comment.
Do you want to change it to Java17 instead or removing this entire condition?
sergiyvamz
approved these changes
Mar 20, 2026
karenc-bq
force-pushed
the
test/hibernate
branch
from
16d3f05 to
c115595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Hibernate version to 7.3.0 and run Hibernate ORM tests against Java versions 17, 21, 22 and 24.
Update sample code to use the latest Spring and Hibernate versions.
Description
This project is built with Java 8, but the latest stable Hibernate version requires at least Java 17.
This PR creates a separate Java 17 source set for the Hibernate integration tests.
This PR also updates
settings.build.ktsto only compile the Spring and Hibernate sample code if the environment is using at least Java 17.To run the tests with Java versions 17, 21, 22, 24, we had to override two additional test files:
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.