Merged
Conversation
aviral92
force-pushed
the
managed-daemons-networking
branch
from
557e36d to
9360241
Compare
JoseVillalta
requested changes
Dec 12, 2025
Contributor
JoseVillalta
left a comment
JoseVillalta
left a comment
There was a problem hiding this comment.
LGTM with minor revisions. Biggest thing is to make sure this gets tested end to end in trunk and non-trunk ENIs.
aviral92
force-pushed
the
managed-daemons-networking
branch
from
9360241 to
10d7a59
Compare
aviral92
force-pushed
the
managed-daemons-networking
branch
from
10d7a59 to
f8a2cde
Compare
JoseVillalta
previously approved these changes
Dec 17, 2025
xxx0624
reviewed
Dec 17, 2025
aviral92
force-pushed
the
managed-daemons-networking
branch
from
f8a2cde to
56940f5
Compare
xxx0624
reviewed
Dec 17, 2025
aviral92
force-pushed
the
managed-daemons-networking
branch
from
56940f5 to
f966279
Compare
xxx0624
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure you've read and understood our contributing guidelines;
https://github.com/aws/amazon-ecs-agent/blob/master/CONTRIBUTING.md
Please provide the following information:
Summary
What does this pull request do?
This PR is for Managed Daemons Networking changes. Currently its only supported for Managed Instances.
Implementation details
How are the changes implemented?
This PR handles a new network mode(daemon-bridge) for daemon tasks, sets up a new network namespace(hots-daemon) for daemon tasks, handles it lifecycle, updates IPtables to support egress, connects to the fargate-bridge for TMDS support.
Testing
Tested with creating a debug AMI with these changes, and see the required namespace get setup when a daemon task is launched and connectivity with fargate-bridge on the host. Also ECS exec works fine with daemon tasks.
New tests cover the changes: Yes.
Description for the changelog
Managed Daemons Networking changes for Managed Instance support.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No.
Does this PR include the addition of new environment variables in the README?
No.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.