Skip to content

Fix neuron per core multi runtime #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spanaik wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix neuron per core multi runtime #2263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84af694
fix(neuron): stop losing per-core Neuron metrics on multi-runtime nodes
spanaik Aug 27, 2026
767fb4b
test(neuron): pipeline-level coverage for multi-runtime per-core data…
spanaik Aug 31, 2026
bc2a719
Merge branch 'main' into fix-neuron-per-core-multi-runtime
spanaik Aug 31, 2026
76f9b94
test(neuron): frame the multi-runtime tests around the invariant, not…
spanaik Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions translator/tocwconfig/sampleConfig/opentelemetry/combined_v1_v2_eks_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,7 @@ processors:
- k8s.pod.name
- k8s.namespace.name
- k8s.container.name
- runtime_tag
groupbyattrs/files:
keys:
- log.file.name
Expand Down Expand Up @@ -1129,15 +1130,9 @@ processors:
transform/cw_k8s_ci_v0_neuron_promote:
error_mode: ignore
metric_statements:
- context: datapoint
- context: resource
statements:
- set(resource.attributes["k8s.pod.name"], attributes["k8s.pod.name"]) where attributes["k8s.pod.name"] != nil
- set(resource.attributes["k8s.namespace.name"], attributes["k8s.namespace.name"]) where attributes["k8s.namespace.name"] != nil
- set(resource.attributes["k8s.container.name"], attributes["k8s.container.name"]) where attributes["k8s.container.name"] != nil
- set(resource.attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "k8s.pod.name") where attributes["k8s.pod.name"] != nil
- delete_key(attributes, "k8s.namespace.name") where attributes["k8s.namespace.name"] != nil
- delete_key(attributes, "k8s.container.name") where attributes["k8s.container.name"] != nil
- set(attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "runtime_tag") where attributes["runtime_tag"] != nil
transform/cw_k8s_ci_v0_promote_node_name:
error_mode: ignore
Expand Down
11 changes: 3 additions & 8 deletions translator/tocwconfig/sampleConfig/opentelemetry/container_insights_node_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ processors:
- k8s.pod.name
- k8s.namespace.name
- k8s.container.name
- runtime_tag
k8sattributes/cw_k8s_ci_v0_node:
auth_type: serviceAccount
exclude:
Expand Down Expand Up @@ -765,15 +766,9 @@ processors:
transform/cw_k8s_ci_v0_neuron_promote:
error_mode: ignore
metric_statements:
- context: datapoint
- context: resource
statements:
- set(resource.attributes["k8s.pod.name"], attributes["k8s.pod.name"]) where attributes["k8s.pod.name"] != nil
- set(resource.attributes["k8s.namespace.name"], attributes["k8s.namespace.name"]) where attributes["k8s.namespace.name"] != nil
- set(resource.attributes["k8s.container.name"], attributes["k8s.container.name"]) where attributes["k8s.container.name"] != nil
- set(resource.attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "k8s.pod.name") where attributes["k8s.pod.name"] != nil
- delete_key(attributes, "k8s.namespace.name") where attributes["k8s.namespace.name"] != nil
- delete_key(attributes, "k8s.container.name") where attributes["k8s.container.name"] != nil
- set(attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "runtime_tag") where attributes["runtime_tag"] != nil
transform/cw_k8s_ci_v0_node_logs_set_log_destination:
error_mode: ignore
Expand Down
11 changes: 3 additions & 8 deletions translator/tocwconfig/sampleConfig/opentelemetry/default_otel_config_aks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ processors:
- k8s.pod.name
- k8s.namespace.name
- k8s.container.name
- runtime_tag
k8sattributes/cw_k8s_ci_v0_node:
auth_type: serviceAccount
exclude:
Expand Down Expand Up @@ -763,15 +764,9 @@ processors:
transform/cw_k8s_ci_v0_neuron_promote:
error_mode: ignore
metric_statements:
- context: datapoint
- context: resource
statements:
- set(resource.attributes["k8s.pod.name"], attributes["k8s.pod.name"]) where attributes["k8s.pod.name"] != nil
- set(resource.attributes["k8s.namespace.name"], attributes["k8s.namespace.name"]) where attributes["k8s.namespace.name"] != nil
- set(resource.attributes["k8s.container.name"], attributes["k8s.container.name"]) where attributes["k8s.container.name"] != nil
- set(resource.attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "k8s.pod.name") where attributes["k8s.pod.name"] != nil
- delete_key(attributes, "k8s.namespace.name") where attributes["k8s.namespace.name"] != nil
- delete_key(attributes, "k8s.container.name") where attributes["k8s.container.name"] != nil
- set(attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "runtime_tag") where attributes["runtime_tag"] != nil
transform/cw_k8s_ci_v0_promote_node_name:
error_mode: ignore
Expand Down
11 changes: 3 additions & 8 deletions translator/tocwconfig/sampleConfig/opentelemetry/default_otel_config_gke.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ processors:
- k8s.pod.name
- k8s.namespace.name
- k8s.container.name
- runtime_tag
k8sattributes/cw_k8s_ci_v0_node:
auth_type: serviceAccount
exclude:
Expand Down Expand Up @@ -762,15 +763,9 @@ processors:
transform/cw_k8s_ci_v0_neuron_promote:
error_mode: ignore
metric_statements:
- context: datapoint
- context: resource
statements:
- set(resource.attributes["k8s.pod.name"], attributes["k8s.pod.name"]) where attributes["k8s.pod.name"] != nil
- set(resource.attributes["k8s.namespace.name"], attributes["k8s.namespace.name"]) where attributes["k8s.namespace.name"] != nil
- set(resource.attributes["k8s.container.name"], attributes["k8s.container.name"]) where attributes["k8s.container.name"] != nil
- set(resource.attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "k8s.pod.name") where attributes["k8s.pod.name"] != nil
- delete_key(attributes, "k8s.namespace.name") where attributes["k8s.namespace.name"] != nil
- delete_key(attributes, "k8s.container.name") where attributes["k8s.container.name"] != nil
- set(attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "runtime_tag") where attributes["runtime_tag"] != nil
transform/cw_k8s_ci_v0_promote_node_name:
error_mode: ignore
Expand Down
11 changes: 3 additions & 8 deletions translator/translate/otel/pipeline/opentelemetry/containerinsights/neuron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,18 +89,13 @@ processors:
- k8s.pod.name
- k8s.namespace.name
- k8s.container.name
- runtime_tag
transform/cw_k8s_ci_v0_neuron_promote:
error_mode: ignore
metric_statements:
- context: datapoint
- context: resource
statements:
- set(resource.attributes["k8s.pod.name"], attributes["k8s.pod.name"]) where attributes["k8s.pod.name"] != nil
- set(resource.attributes["k8s.namespace.name"], attributes["k8s.namespace.name"]) where attributes["k8s.namespace.name"] != nil
- set(resource.attributes["k8s.container.name"], attributes["k8s.container.name"]) where attributes["k8s.container.name"] != nil
- set(resource.attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "k8s.pod.name") where attributes["k8s.pod.name"] != nil
- delete_key(attributes, "k8s.namespace.name") where attributes["k8s.namespace.name"] != nil
- delete_key(attributes, "k8s.container.name") where attributes["k8s.container.name"] != nil
- set(attributes["aws.neuron.runtime.tag"], attributes["runtime_tag"]) where attributes["runtime_tag"] != nil
- delete_key(attributes, "runtime_tag") where attributes["runtime_tag"] != nil
transform/cw_k8s_ci_v0_neuron_hw_attrs:
error_mode: ignore
Expand Down
Loading
Loading