-
Notifications
You must be signed in to change notification settings - Fork 478
Add meeting session timing tracking and signaling #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,6 +27,7 @@ message SdkSignalFrame { | |
| PRIMARY_MEETING_JOIN_ACK = 26; | ||
| PRIMARY_MEETING_LEAVE = 27; | ||
| NOTIFICATION = 34; | ||
| MEETING_SESSION_TIMING = 43; | ||
| } | ||
| required uint64 timestamp_ms = 1; | ||
| required Type type = 2; | ||
|
|
@@ -52,6 +53,7 @@ message SdkSignalFrame { | |
| optional SdkPrimaryMeetingJoinAckFrame primary_meeting_join_ack = 27; | ||
| optional SdkPrimaryMeetingLeaveFrame primary_meeting_leave = 28; | ||
| optional SdkNotificationFrame notification = 35; | ||
| optional SdkMeetingSessionTimingFrame meeting_session_timing = 44; | ||
| } | ||
|
|
||
| message SdkErrorFrame { | ||
|
|
@@ -283,6 +285,8 @@ message SdkMetric { | |
| VIDEO_DISCARDED_PPS = 47; | ||
| VIDEO_PLIS_SENT = 48; | ||
| VIDEO_RECEIVED_JITTER_MS = 49; | ||
| VIDEO_LOCAL_RENDER_FPS = 52; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Couldn't end up getting local render FPS working unfortunately (since most apps do not bind the local tile) but just leaving it for the future. |
||
| VIDEO_REMOTE_RENDER_FPS = 56; | ||
| VIDEO_INPUT_HEIGHT = 60; | ||
| VIDEO_ENCODE_HEIGHT = 64; | ||
| VIDEO_SENT_QP_SUM = 66; | ||
|
|
@@ -503,3 +507,60 @@ enum SdkVideoCodecCapability { | |
| VP9_PROFILE_0 = 8; | ||
| AV1_MAIN_PROFILE = 11; | ||
| }; | ||
|
|
||
| message SdkMeetingSessionTimingFrame { | ||
| repeated SdkMeetingSessionSignalingTiming signaling = 1; | ||
| repeated SdkMeetingSessionRemoteAudioTiming remote_audio = 2; | ||
| repeated SdkMeetingSessionLocalAudioTiming local_audio = 3; | ||
| repeated SdkMeetingSessionLocalVideoTiming local_video = 4; | ||
| repeated SdkMeetingSessionRemoteVideoTiming remote_videos = 5; | ||
| } | ||
|
|
||
| message SdkMeetingSessionSignalingTiming { | ||
| optional int64 start_ms = 1; | ||
| optional int64 join_sent_ms = 2; | ||
| optional int64 join_ack_received_ms = 3; | ||
| optional int64 transport_connected_ms = 4; | ||
| optional int64 create_offer_ms = 5; | ||
| optional int64 set_local_description_ms = 6; | ||
| optional int64 set_remote_description_ms = 7; | ||
| optional int64 ice_gathering_start_ms = 8; | ||
| optional int64 ice_gathering_complete_ms = 9; | ||
| optional int64 ice_connected_ms = 10; | ||
| optional int64 subscribe_sent_ms = 11; | ||
| optional int64 subscribe_ack_ms = 12; | ||
| optional bool timed_out = 13; | ||
| } | ||
|
|
||
| message SdkMeetingSessionRemoteAudioTiming { | ||
| optional int64 added_ms = 1; | ||
| optional int64 first_packet_received_ms = 2; | ||
| optional int64 first_frame_rendered_ms = 3; | ||
| optional bool timed_out = 4; | ||
| optional bool removed = 5; | ||
| } | ||
|
|
||
| message SdkMeetingSessionLocalAudioTiming { | ||
| optional int64 added_ms = 1; | ||
| optional int64 first_frame_captured_ms = 2; | ||
| optional int64 first_packet_sent_ms = 3; | ||
| optional bool timed_out = 4; | ||
| optional bool removed = 5; | ||
| } | ||
|
|
||
| message SdkMeetingSessionLocalVideoTiming { | ||
| optional int64 added_ms = 1; | ||
| optional int64 first_frame_captured_ms = 2; | ||
| optional int64 first_frame_sent_ms = 3; | ||
| optional bool timed_out = 4; | ||
| optional bool removed = 5; | ||
| } | ||
|
|
||
| message SdkMeetingSessionRemoteVideoTiming { | ||
| optional uint32 group_id = 1; | ||
| optional int64 added_ms = 2; | ||
| optional int64 first_packet_received_ms = 3; | ||
| optional int64 first_frame_rendered_ms = 4; | ||
| optional bool timed_out = 5; | ||
| optional bool removed = 6; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ end | |
|
|
||
| # Just so the devs can see. | ||
| puts 'Auditing development dependencies. You should address any findings.' | ||
| system('npm audit --omit=prod') | ||
| system('npm audit --include=dev') | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unrelated change |
||
|
|
||
| puts '---' | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,10 +20,13 @@ const workerTsconfig = 'tsconfig.mediatransformworker.json'; | |
| const workerTsconfigContent = `{ | ||
| "extends": "./tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "module": "ES2015", | ||
| "module": "es2015", | ||
| "moduleResolution": "node", | ||
| "outDir": "../build", | ||
| "rootDir": "../src" | ||
| "outDir": "../build/mediatransformworker", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unrelated change |
||
| "rootDir": "../src", | ||
| "tsBuildInfoFile": "./tsconfig.mediatransformworker.tsbuildinfo", | ||
| "incremental": true, | ||
| "composite": false | ||
| }, | ||
| "include": [ | ||
| "../src/encodedtransformworker/**/*.ts" | ||
|
|
@@ -55,7 +58,7 @@ fs.unlinkSync(`${configDir}/${workerTsconfig}`); | |
|
|
||
| // Read all transpiled worker files and bundle them inline | ||
| // Order matters: dependencies must come before classes that use them | ||
| const buildDir = './build/encodedtransformworker'; | ||
| const buildDir = './build/mediatransformworker/encodedtransformworker'; | ||
| const workerFiles = [ | ||
| 'EncodedTransform.js', | ||
| 'RedundantAudioEncodedTransform.js', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change