Skip to content

Fix: Helm values with correct key names in README - #158

Open
same7ammar wants to merge 1 commit into
aws-samples:mainfrom
same7ammar:main
Open

Fix: Helm values with correct key names in README#158
same7ammar wants to merge 1 commit into
aws-samples:mainfrom
same7ammar:main

Conversation

@same7ammar

Copy link
Copy Markdown

Description of issue:

I have tried the sample of app of apps yaml but looks like the values provided to helm are not correct .

    path: chart
    helm:
      release:   add-ons
      values: |
        cluster-autoscaler:
          enable: true
        metrics-server:
          enable: true

i can deploy it successfully the apps are not showing , i have checked the values.yml in https://github.com/aws-samples/eks-blueprints-add-ons/blob/main/chart/values.yaml#L88

you will see :

# Cluster Autoscaler Values
clusterAutoscaler:
  enable: false
  serviceAccountName:`

So correct values show be :

  targetRevision: HEAD
    path: chart
    helm:
      release: add-ons
      values: |
        clusterAutoscaler:
          enable: true
        metricsServer:
          enable: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant