Closed
Conversation
pbelevich
force-pushed
the
nemo2_performance
branch
from
fb010bf to
0dbc76a
Compare
nghtm
suggested changes
Aug 12, 2025
| export NEMORUN_HOME=/fsxl/.../nemo_run | ||
| ``` | ||
|
|
||
| ### Build Docker Image |
Contributor
There was a problem hiding this comment.
It's not clear to me here reading this if we are telling users to extend docker image from nvcr.io with EFA variables?
is that what we mean by "continue with EFA installation"?
If so - can we link out to the official instructions to install EFA into a docker container
Contributor
|
Please wait on providing feedback/merging. Let's merge all together once we have perf assets ready/converged. |
KeitaW
reviewed
Aug 13, 2025
| --account $(whoami) --partition p6 -i ./aws-nemo.sqsh \ | ||
| --gpu b200 -c fp8 --num_gpus 64 -gb 128 -mb 1 -tp 2 -pp 4 -cp 2 -vp 5 -ep 1 | ||
| ``` | ||
| error |
Contributor
There was a problem hiding this comment.
Maybe we should elaborate what error we have encountered?
KeitaW
reviewed
Aug 13, 2025
| @@ -0,0 +1,281 @@ | |||
| # Performance | |||
|
|
|||
| This document describes the process of performance measurements of NeMo 2.x framework. | |||
Contributor
There was a problem hiding this comment.
- What is the desired output?
- How can we run the performance measurements for multi-nodes distributed training case?
- Add Table of Contents and improve document structure - Add Prerequisites section with NeMo version compatibility matrix - Update EFA installation instructions with links to AWS docs - Add Environment Variables configuration section - Add Expected Outputs section explaining performance metrics - Add Multi-Node Distributed Training section with examples - Fix 'error' placeholder with explanatory note about B200 configuration - Add section headers for Mixtral, Nemotron, and DeepSeek models - Improve Fine-Tuning section with better formatting and HF_TOKEN note - Add comprehensive Troubleshooting section - Update EFA installer version from 1.43.1 to 1.47.0 in Dockerfile Fixes review comments from nghtm and KeitaW
Contributor
|
@pbelevich can you please review the new changes I've added based on the comments? Let me know if you agree then we can approve this PR. |
Contributor
|
Addressed in #953 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.