Conversation
Contributor
|
Can you update the description to include the changes related to modifying |
ishajos
approved these changes
Feb 6, 2026
Member
|
comment: We need some monitoring around if/if not the payload compression is not corrupted and the entire payload is received as was sent from the client. I think the smoke tests can achieve this as long as we check the entire payload carefully. Otherwise we run a risk of having a silent bug which will never be caught |
ps863
reviewed
Feb 9, 2026
Member
|
comment: We should point out somewhere in docs for users using proxies and modifying the payload, they would need to update their proxy level configs to handle compressed requests (if they choose to opt in) |
ps863
approved these changes
Feb 9, 2026
Collaborator
Author
|
okay will
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an opt-in feature to support compression via the CompressionStream API. Currently, we are hard coded to use GZIP algorithm, 2KB minimum raw size to compress, and 80% minimum compression ratio to dispatch. In the future, we may expose these configurations. For now, end user just needs to add this to config to enable:
Also, I updated InternalLogger to use a boolean to check if debug mode is enabled, so that we don't have to do all these annoying config.debug lookups.
Testing
Updated unit, integ. Smoke tests are missing right now, and honestly it is pretty annoying to write refactor them based on how they are currently setup, and I couldn't get them working. I will follow up with a separate PR for smoke tests
Manual testing
GZIP compression shown in network tab payload
GZIP compression ingestion in RUM console
GZIP compression ingestion in logs
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.