added support for EC, ECPrimeRandom algorithms#5552
Open
ruslan-h wants to merge 7 commits intoaws-amplify:mainfrom
Open
added support for EC, ECPrimeRandom algorithms#5552ruslan-h wants to merge 7 commits intoaws-amplify:mainfrom
ruslan-h wants to merge 7 commits intoaws-amplify:mainfrom
Conversation
Author
|
@mattcreaser @thisisabhash @harsh62, could you please take a look at this PR? |
Contributor
|
@ruslan-h Thank you for taking the time on the implementation. The AWS iOS SDK is currently in maintenance mode. As a result, we are no longer pulling in feature requests / enhancements. Please take a look at the eventual replacement library: https://github.com/aws/aws-iot-device-sdk-swift. If your use case isn't fully supported here, please create a feature request, as the IoT team is actively working on the library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Support for EC, ECPrimeRandom algorithms #905]
AWSIoT/Internal/AWSIoTKeychainby introducingKeyAlgorithmTypeenum representing common cryptographic key algorithms, added overrides for(BOOL)deleteAsymmetricKeysWithPublicTag,(BOOL)isValidCertificate,(SecIdentityRef)getIdentityRef,(BOOL)deleteAsymmetricKeysWithPublicTagand other util functions to accept additional parameterkeyAlgorithmType:(KeyAlgorithmType)keyAlgorithmType.AWSIoT/AWSIoTDataManagerfor(BOOL)connectWithClientId,(BOOL)connectUsingALPNWithClientIdto accept additional parameterkeyAlgorithmType:(KeyAlgorithmType)keyAlgorithmType.AWSIoT/AWSIoTManagerfor(BOOL)importIdentityFromPKCS12Data,(BOOL)isValidCertificate,(BOOL)deleteCertificateWithCertificateIdAndKeyAlgorithmTypeto accept additional parameterkeyAlgorithmType:(KeyAlgorithmType)keyAlgorithmType.@aws-amplify/amplify-native for visibility