chore(gen2-migration): stable & e2e based snapshots#14782
Merged
iliapolo merged 72 commits intogen2-migrationfrom Apr 15, 2026
Merged
chore(gen2-migration): stable & e2e based snapshots#14782iliapolo merged 72 commits intogen2-migrationfrom
iliapolo merged 72 commits intogen2-migrationfrom
Conversation
Add a normalize script that replaces run-specific values (deploymentName, envName, envHash, sandboxHash, commitHash, CFN nested stack hashes) with stable placeholders in snapshot filenames and content, making snapshots deterministic across e2e runs. Use a fixed --identifier e2e for ampx sandbox deployments instead of deriving the stack prefix from os.userInfo().username. Regenerate and normalize project-boards snapshots. --- Prompt: commit everything
normalize, update docs Remove getAllFiles wrapper, unused os import, and username sanitization from sanitize.ts. Fix orphaned JSDoc in normalize.ts. Update sanitize JSDoc to reflect current behavior. Add snapshot post-processing documentation to the E2E system README covering normalization and sanitization steps. Slim down the migration-apps README to point to the E2E README for details while keeping the manual invocation instructions local. --- Prompt: commit
replacements, restore gen2 API key sanitization Remove the output value replacement logic from sanitize.ts — it was replacing values inside pre.generate snapshots that the generate command depends on. Restore the original gen2 API key extraction and sanitization. Normalize now only renames files, no content replacement. --- Prompt: commit
on API key sanitization --- Prompt: made some changes, commit
iliapolo
changed the title
Contributor
|
reviewed in-person. |
sai-ray
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR improves the snapshot sanitization and normalization pipeline for the gen2 migration e2e system. The main goal is to make snapshots as stable as possible so that rerunning them produces the minimal
amount of changes.
Normalization
A new normalize step was added that runs before sanitization. It replaces run-specific values (random env names, CFN stack hashes) in both file content and filenames with deterministic placeholders,
keeping snapshot filenames stable across runs.
Sandbox identifier
The sandbox deployment now uses
--identifier e2efor a deterministic stack name prefix instead of the OS username.Issue #, if available
N/A
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.