Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4088 +/- ##
==========================================
+ Coverage 90.45% 90.46% +0.01%
==========================================
Files 941 941
Lines 60385 60386 +1
Branches 1145 1145
==========================================
+ Hits 54621 54631 +10
+ Misses 5254 5248 -6
+ Partials 510 507 -3 🚀 New features to boost your workflow:
|
actionless
reviewed
Mar 17, 2026
| pfx##_array_splice(pfx##_array_t *arr, int pos, int len, \ | ||
| type_t items[], int count) \ | ||
| { \ | ||
| assert (pos >= 0 && len >= 0 && count >= 0); \ |
Member
There was a problem hiding this comment.
i wonder should it be moved here to just change count from >= to > 0?
Contributor
Author
There was a problem hiding this comment.
No, passing 0 is indeed a valid operation.
array_take is what passes 0.
Contributor
Author
There was a problem hiding this comment.
Passing 0 to count means that no elements are inserted into the array.
Just like with array_take, if you only need to remove some elements from the array, you can pass 0 to count.
actionless
approved these changes
Mar 17, 2026
Contributor
Author
|
This optimization is actually quite useful; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might reduce the overhead of some memcpy calls.