fix(naughty): ensure default timeout applies without ruled.notification

lib/naughty/notification.lua

@@ -1101,12 +1101,10 @@ local function create(args)
     end
 
     -- Because otherwise the setter logic would not be executed
-    if n._private.timeout then
-        n:set_timeout(n._private.timeout
-            or (n.preset and n.preset.timeout)
-            or cst.config.timeout
-        )
-    end
+    n:set_timeout(n._private.timeout
+        or (n.preset and n.preset.timeout)
+        or cst.config.defaults.timeout
+    )
 
     return n
 end

tests/test-naughty-timeout-init.lua

@@ -1,37 +1,107 @@
--- Test that setting timeout=0 on an existing notification stops and clears
--- the old timer (regression test for set_timeout() only stopping the timer
--- inside the timeout > 0 branch).
+-- Test: Notification timeout bugs.
+--
+-- 1. Setting timeout=0 doesn't stop existing timer:
+--    set_timeout() at notification.lua only stops the old timer inside
+--    the `if timeout > 0` block. When timeout is 0 (meaning "never expire"),
+--    the else branch never stops the old timer. So setting n.timeout = 0
+--    after creation leaves the old timer running.
+--
+-- 2. Default timeout never starts when no explicit timeout is given:
+--    The constructor guard `if n._private.timeout then` skips set_timeout()
+--    when timeout is nil (not provided). Without ruled.notification, this
+--    means notifications with no explicit timeout never expire.
 
-require("naughty")
+local naughty = require("naughty")
 local notification = require("naughty.notification")
+local runner = require("_runner")
+
+-- Register a request::preset handler to enable the new API path.
+naughty.connect_signal("request::preset", function() end)
+
+-- Register a display handler so notifications are "shown"
+naughty.connect_signal("request::display", function(n)
+    require("naughty.layout.box") { notification = n }
+end)
+
+local n_timeout_zero = nil
+local n_default = nil
 
 local steps = {}
 
+-- Setting timeout=0 after creation should stop the existing timer.
+-- Create notification with timeout=5 (creates a timer), then set timeout=0.
+-- The old timer should stop, but it doesn't because the timer-stop code is
+-- inside the `if timeout > 0` block.
 table.insert(steps, function()
-    -- Create a notification with a 5-second timeout (starts a timer).
-    local n = notification {
-        title   = "timeout-test",
+    n_timeout_zero = notification {
+        title   = "timeout zero after creation",
+        message = "Setting timeout=0 should stop the timer",
         timeout = 5,
     }
 
-    assert(n.timer, "expected a timer after timeout=5")
-    assert(n.timer.started, "expected timer to be started")
+    assert(n_timeout_zero, "notification was not created")
+    assert(n_timeout_zero.timer ~= nil, "timer should exist for timeout=5")
+    assert(n_timeout_zero.timer.started,
+        "timer should be running for timeout=5")
+
+    -- Now set timeout to 0, meaning "never expire"
+    n_timeout_zero.timeout = 0
+
+    assert(n_timeout_zero.timeout == 0,
+        string.format("expected timeout=0, got %d", n_timeout_zero.timeout))
 
-    -- Now set timeout=0 ("never expire").  The old timer must be stopped
-    -- and the reference cleared.
-    n.timeout = 0
+    -- The old timer (5s) should have been stopped and cleared.
+    -- set_timeout(0) must stop the old timer and nil out self.timer so that
+    -- reset_timeout() doesn't accidentally restart a stale reference.
+    assert(n_timeout_zero.timer == nil,
+        "timer should be nil after setting timeout=0")
 
-    assert(not n.timer, "expected timer to be nil after timeout=0")
+    return true
+end)
+
+-- After setting timeout=0, reset_timeout() must not restart a stale timer.
+-- reset_timeout() checks `self.timer and not self.timer.started` and would
+-- restart the old (stopped) timer if set_timeout(0) forgot to nil it out.
+table.insert(steps, function()
+    assert(n_timeout_zero, "notification should still exist")
 
-    -- reset_timeout() should be safe and not restart a stale timer.
-    n:reset_timeout()
+    n_timeout_zero:reset_timeout()
 
-    assert(not n.timer, "expected timer to still be nil after reset_timeout()")
+    assert(n_timeout_zero.timer == nil,
+        "regression: reset_timeout() after timeout=0 should not recreate timer")
 
-    -- Clean up.
-    n:destroy()
+    return true
+end)
 
+-- Default timeout never starts when no explicit timeout given.
+table.insert(steps, function()
+    n_default = notification {
+        title = "default timeout test",
+        message = "Should expire with default timeout",
+        -- No timeout specified - should get default from cst.config
+    }
+
+    assert(n_default, "notification was not created")
+
+    -- The default timeout from cst.config.defaults is 5 seconds.
+    -- set_timeout() should have been called with that value.
+    assert(n_default.timer ~= nil,
+        "regression: notification without explicit timeout should get a timer")
+
+    assert(n_default.timer.started,
+        "timer exists but is not started")
+
+    assert(n_default.timeout == 5,
+        string.format("expected default timeout=5, got %d", n_default.timeout))
+
+    return true
+end)
+
+-- Cleanup
+table.insert(steps, function()
+    n_timeout_zero:destroy()
+    n_default:destroy()
     return true
 end)
 
-require("_runner").run_steps(steps)
+runner.run_steps(steps)