fix: correct mutex unlock in IsClosed.Err() method>#129
Merged
maranqz merged 2 commits intoavito-tech:mainfrom Oct 24, 2025
honeynil:fix/is-closed-mutex-deadlock
Merged
fix: correct mutex unlock in IsClosed.Err() method>#129maranqz merged 2 commits intoavito-tech:mainfrom honeynil:fix/is-closed-mutex-deadlock
maranqz merged 2 commits intoavito-tech:mainfrom
honeynil:fix/is-closed-mutex-deadlock
Conversation
Collaborator
Pull Request Test Coverage Report for Build 18771899929Details
💛 - Coveralls |
* extend test to catch this problem in the future
Member
|
Thank you for catching and the fix. ❤️ I extended test and will release it in short time. |
maranqz
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a critical concurrency bug in the Err() method where defer was
calling RLock() instead of RUnlock(). This caused read locks to
accumulate without being released, leading to potential deadlocks when
CloseWithCause() attempted to acquire a write lock.
The bug could manifest in high-concurrency scenarios where multiple
goroutines call Err() while another attempts to call CloseWithCause().
Changes: