Skip to content

fix(v1): replace russian С to english C in trm.CtxManager type#126

Merged
maranqz merged 4 commits intoavito-tech:v1from
dro-sh:russian-to-english-v1
Aug 31, 2025
Merged

fix(v1): replace russian С to english C in trm.CtxManager type#126
maranqz merged 4 commits intoavito-tech:v1from
dro-sh:russian-to-english-v1

Conversation

@dro-sh
Copy link
Contributor

@dro-sh dro-sh commented Aug 21, 2025

duplicate for #125 for v1

@dro-sh
Copy link
Contributor Author

dro-sh commented Aug 21, 2025

@maranqz, also open PR for v1

@maranqz
Copy link
Member

maranqz commented Aug 23, 2025

Let's set golangci-lint v1.56.2 in github action to solve linter errors.

@maranqz maranqz requested review from Copilot and maranqz August 24, 2025 09:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dro-sh
Copy link
Contributor Author

dro-sh commented Aug 27, 2025

@maranqz set golangci-lint github action to v1.56.2

--health-interval 10s
--health-timeout 5s
--health-retries 5
--health-cmd "redis-cli ping" --health-interval 10s --health-timeout 5s --health-retries 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoformatter :/

redis/context.go Outdated
@@ -14,11 +14,11 @@ var DefaultCtxGetter = NewCtxGetter(trmcontext.DefaultManager)

// CtxGetter gets redis.Pipeliner from trm.СtxManager by casting trm.Transaction to redis.UniversalClient.
Copy link
Member

@maranqz maranqz Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix please in CtxManager comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dro-sh dro-sh force-pushed the russian-to-english-v1 branch from 7462fb1 to 1d37a8f Compare August 28, 2025 20:48
@dro-sh dro-sh requested a review from maranqz August 30, 2025 18:43
@maranqz maranqz merged commit 5ff11a1 into avito-tech:v1 Aug 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants