Add jseq. - #6631
Open
bobg wants to merge 2 commits into
Open
Conversation
Automated Quality ChecksRequired checks✅ Repo: accessible, has go.mod and SemVer release Additional checks✅ License: MIT
Coverage: https://app.codecov.io/gh/your-org/your-project |
Contributor
Author
|
Hm, despite what the automatic check above claims, there is in fact a coverage link in my PR description. Also, the "single item" check overlooks the conflicting requirement that I remove entries around my addition that do not meet the quality standards (which I have done). |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required links
Provide the links below. Our CI will automatically validate them.
Pre-submission checklist
Repository requirements
These are validated automatically by CI:
go.modfile and at least one SemVer release (vX.Y.Z).These are recommended and reported as warnings:
Pull Request content
These are validated automatically by CI:
Category quality
Note: new categories require a minimum of 3 packages.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure they still meet the Quality Standards.
Please delete one of the following lines:
I removed the following packages around my addition: (please give a short reason for each removal)
I removed JSON-to-Go because https://github.com/mholt/json-to-go is not written in Go (it's Typescript) and does not contain a
go.modfile.Likewise JSON-to-Proto, which doesn't even have anything to do with Go.
Thanks for your PR, you're awesome! 😎