Skip to content

StopSign and Cone Detection - #1131

Open
cfox570 wants to merge 3 commits into
autorope:tf_2_9from
cfox570:tf_2_9
Open

StopSign and Cone Detection#1131
cfox570 wants to merge 3 commits into
autorope:tf_2_9from
cfox570:tf_2_9

Conversation

@cfox570

@cfox570 cfox570 commented May 19, 2023

Copy link
Copy Markdown
Contributor

New parts to control Donkeycar to stop at Stop Signs and swerve around traffic cones.

New parts to control Donkeycar to stop at Stop Signs and swerve around traffic cones.

@DocGarbanzo DocGarbanzo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an interesting addition to the project. Do you have a video, or similar, where this can be seen in action? I only have minor comments to the code.

Comment thread donkeycar/parts/object_detector/conemodel.tflite Outdated
from tflite_support.task import processor
from tflite_support.task import vision

'''

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like commented code, can you remove this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Comment thread donkeycar/parts/object_detector/detector.py Outdated
Comment thread donkeycar/parts/object_detector/od_protocol.py Outdated
Comment thread donkeycar/parts/object_detector/od_protocol.py Outdated
Comment thread donkeycar/parts/object_detector/od_protocol.py Outdated
Comment thread donkeycar/parts/object_detector/od_protocol.py Outdated
Removed extraneous code and unnecessary comments
@cfox570

cfox570 commented Jul 6, 2023

Copy link
Copy Markdown
Contributor Author

This looks like an interesting addition to the project. Do you have a video, or similar, where this can be seen in action? I only have minor comments to the code.

Working on making a video. Expect to finish by Sunday.

Remove the large files.
@cfox570

cfox570 commented Jul 6, 2023

Copy link
Copy Markdown
Contributor Author

I am not clear why the MacOS.yml failed.

@Ezward Ezward left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to need changes to documentation for this. We have some docs on the current stop sign detector Stop Sign Detection; those will have to be changed. Can you open a parallel PR in the docs repository for the documentation changes? https://github.com/autorope/donkeydocs. For an example of what we are doing for docs in new features, see http://docs.donkeycar.com/guide/path_follow/path_follow/ and http://docs.donkeycar.com/guide/computer_vision/computer_vision/

@cfox570

cfox570 commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

I created a pull request for this part. See autorope/donkeydocs#51

@cfox570

cfox570 commented Jul 9, 2023

Copy link
Copy Markdown
Contributor Author

where this can be seen in action?

I created two videos.... Stop Sign detection and Traffic Cone avoidance.

And I added the video to the DonkeyDocs pull request

@shreyasrawat

Copy link
Copy Markdown

where this can be seen in action?

I created two videos.... Stop Sign detection and Traffic Cone avoidance.

And I added the video to the DonkeyDocs pull request

Hello cfox570, how were you able to implement this into the donkeycar program?

@cfox570

cfox570 commented Jun 10, 2024

Copy link
Copy Markdown
Contributor Author

where this can be seen in action?

I created two videos.... Stop Sign detection and Traffic Cone avoidance.
And I added the video to the DonkeyDocs pull request

Hello cfox570, how were you able to implement this into the donkeycar program?

The pull request was attached to an older branch. Here is the code url. https://github.com/autorope/donkeycar/pull/1131/files. You will need to add the parts files and modify the complete template to implement. There is also a pull request to the documentation. See this link https://github.com/autorope/donkeydocs/pull/51/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants