feat: Expose useParenthesesForGroovy configuration for Groovy DSL syntax.#1648
Open
Freeezzzi wants to merge 1 commit intoautonomousapps:mainfrom
Open
feat: Expose useParenthesesForGroovy configuration for Groovy DSL syntax.#1648Freeezzzi wants to merge 1 commit intoautonomousapps:mainfrom
Freeezzzi wants to merge 1 commit intoautonomousapps:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #1522
useParenthesesForGroovyparam was added toAdvicePrinterto support parentheses syntax in Groovy build scripts.From 1522 PR description:
The parameter existed in the code but it was never exposed as a configurable option - it always defaulted to false.
For proof, here's a search in repository: https://github.com/search?q=repo%3Aautonomousapps%2Fdependency-analysis-gradle-plugin%20useParenthesesForGroovy&type=code
This meant that even if a project consistently used parentheses syntax in Groovy build scripts:
The plugin's advice output (projectHealth, buildHealth) and build script rewriting (fixDependencies) would always produce space:
How I propose to configure
useParenthesesForGroovyflag is now configurable via thestructure {}DSL block.Configure in settings.gradle[.kts] or root build.gradle[.kts]: