Skip to content

fix(devContext): only the first occurrence of a caveat parameter coul…#2972

Merged
miparnisari merged 1 commit intomainfrom
caveat-fixing
Mar 20, 2026
Merged

fix(devContext): only the first occurrence of a caveat parameter coul…#2972
miparnisari merged 1 commit intomainfrom
caveat-fixing

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Mar 18, 2026

…d be found

Description

This was found in #2965 and I am extracting it into its own PR.

The issue is shown in the second screenshot - notice how hovering over the second day shows nothing:

image image

Testing

In VSCode:

image

References

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Mar 18, 2026
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.74%. Comparing base (3bd3501) to head (5640db4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/development/schema_position_mapper.go 0.00% 19 Missing ⚠️

❌ Your project status has failed because the head coverage (25.74%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2972       +/-   ##
===========================================
- Coverage   67.57%   25.74%   -41.83%     
===========================================
  Files         499      431       -68     
  Lines       61060    54994     -6066     
===========================================
- Hits        41256    14152    -27104     
- Misses      16938    39416    +22478     
+ Partials     2866     1426     -1440     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari marked this pull request as ready for review March 18, 2026 22:53
@miparnisari miparnisari requested a review from a team as a code owner March 18, 2026 22:53
@miparnisari miparnisari force-pushed the caveat-fixing branch 2 times, most recently from cea2149 to 8ab9cb1 Compare March 19, 2026 21:25
@miparnisari miparnisari enabled auto-merge (squash) March 20, 2026 18:27
@miparnisari miparnisari force-pushed the caveat-fixing branch 3 times, most recently from 8ab9cb1 to c5851bc Compare March 20, 2026 18:47
@miparnisari miparnisari merged commit 70fe885 into main Mar 20, 2026
43 of 45 checks passed
@miparnisari miparnisari deleted the caveat-fixing branch March 20, 2026 19:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants