Closed
Conversation
Adds MustSafecast function following the MustBugf pattern: - Panics in tests when conversion fails - Returns zero value in production with warning log - Replaces manual safecast error handling across codebase Closes authzed#2714
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (42.10%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
===========================================
- Coverage 77.01% 42.10% -34.90%
===========================================
Files 462 419 -43
Lines 49121 44224 -4897
===========================================
- Hits 37825 18617 -19208
- Misses 8509 23834 +15325
+ Partials 2787 1773 -1014 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
35f95ea to
4cd4dc9
Compare
Contributor
Author
|
Closing as duplicate of #2638 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the protogetter linter to catch nil pointer dereferences on proto getters.
Fixes #2633
Changes
protogetterto the list of enabled linters in.golangci.yaml