Skip to content

Upgrade some deps#124

Merged
tstirrat15 merged 1 commit intomainfrom
upgrade-some-deps
Feb 25, 2026
Merged

Upgrade some deps#124
tstirrat15 merged 1 commit intomainfrom
upgrade-some-deps

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Feb 25, 2026

Description

Things I noticed while working on #122

Changes

  • Bump a bunch of deps

Testing

Review. See that tests pass and lints pass. Do a quick scan of the preview.

@vercel
Copy link

vercel bot commented Feb 25, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
playground Ready Ready Preview, Comment Feb 25, 2026 11:25pm

Request Review

@tstirrat15 tstirrat15 force-pushed the upgrade-some-deps branch 2 times, most recently from 184b491 to 86e3f6d Compare February 25, 2026 16:28
tstirrat15
tstirrat15 commented Feb 25, 2026
View reviewed changes
Copy link
Contributor Author

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

src/components/panels/base/common.tsx

import { createStyles, makeStyles, Theme } from "@material-ui/core/styles";
import { type ReactNode } from "react";
import "react-reflex/styles.css";
Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed with the new version of oxfmt.

src/components/panels/base/components.tsx Outdated
return (
/* @ts-expect-error MUI's types are screwy */
<AppBar position="relative" color="default">
{/* @ts-expect-error MUI's types are screwy */}
Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a ton of these changes - the issue is that MUI types things as => Jsx.Element, which is wrong according to react 19's types. The fix will be removing the use of MUI.

Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm material isn't compatible with React19 because it uses findDOMNode everywhere.

src/components/panels/base/reflexed.tsx
horizontal: {
title: "Bottom",
icon: <HorizontalSplitIcon />,
icon: <SquareSplitHorizontal />,
Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced a number of the MUI icons with Lucide icons where it was a 1-1 replacement.

src/components/panels/terminal.tsx
}, [zedState, classes.loadBar]);

const inputRef = useRef<HTMLInputElement>();
const inputRef = useRef<HTMLInputElement>(null);
Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a type change with React 19.

src/components/relationshipeditor/commentcell.tsx
@@ -1,6 +1,6 @@
import { CustomCell, CustomRenderer, GridCellKind } from "@glideapps/glide-data-grid";
import TextField from "@material-ui/core/TextField";
import React, { MutableRefObject, useEffect, useRef } from "react";
Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MutableRefObject is deprecated in favor of RefObject. I made this change in a handful of places.

src/components/EditorDisplay.tsx Outdated
Comment on lines +434 to +435
{props.diff ? (
/* @ts-expect-error Monaco's types are screwy */
Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had bugged me - typescript wasn't able to be aware of the types of the two flavors of editor because we weren't being explicit about it. It also meant we had to mess with key props, which made things messier.

Joke's on me, though, cuz the official react bindings for the monaco editor are typed in a screwy way for react 19.

src/components/EmbeddedPlayground.tsx
Comment on lines -11 to -12
} from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get rid of fontawesome entirely which is exciting

.oxfmtrc.jsonc
"$schema": "./node_modules/oxfmt/configuration_schema.json",
"ignorePatterns": ["src/spicedb-common/protodefs", "examples", "public"],
"experimentalSortImports": {
"sortImports": {
Copy link
Contributor Author

@tstirrat15 tstirrat15 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer experimental :D

@tstirrat15 tstirrat15 force-pushed the upgrade-some-deps branch 2 times, most recently from 633bb12 to f2c1064 Compare February 25, 2026 18:15
alecmerdler
alecmerdler previously approved these changes Feb 25, 2026
View reviewed changes
@tstirrat15 tstirrat15 merged commit 31f0734 into main Feb 25, 2026
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alecmerdler alecmerdler alecmerdler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tstirrat15 @alecmerdler