[WIP] Specify behavior of disabled user login with biometric#5132
Open
tung2744 wants to merge 1 commit intoauthgear:mainfrom
Open
[WIP] Specify behavior of disabled user login with biometric#5132tung2744 wants to merge 1 commit intoauthgear:mainfrom
tung2744 wants to merge 1 commit intoauthgear:mainfrom
Conversation
tung2744
force-pushed
the
spec-biometric-disabled-user
branch
from
fcca90e to
2cafdf7
Compare
Contributor
Author
|
| list_enabled: false | ||
| ``` | ||
|
|
||
| ## Errors |
Contributor
There was a problem hiding this comment.
Given that the OAuth error shape is quite limited, I am thinking if we want to introduce a way to include our API error into a OAuth response.
https://datatracker.ietf.org/doc/html/rfc6749#section-8.5 specifies how to add additional error codes.
We can add a new error code authgear_error. When error=authgear_error, the response will have an extra field authgear_error, where the value is a Authgear API error JSON object.
Then the new SDKs be taught to decode error=authgear_error, throw an instance ServerError to handle this.
Contributor
Author
There was a problem hiding this comment.
As oauth error could appear in the url, I am not sure if it is appropriate to add field to store the api error json object which could be long.
tung2744
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.