feat: unified app-id across all platforms (Windows, X11, GTK, Wayland)#739
Merged
Merged
Conversation
efb9d17 to
f24933a
Compare
Collaborator
Author
|
completely vibecoded shit |
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a global app_id to the aui::app_info namespace, integrating it into window initialization across Linux and Windows platforms for consistent application identification. Feedback indicates that the aui_app CMake macro requires updates to correctly parse custom IDs and implement the described auto-generation logic. Additionally, the reviewer recommended using unique filenames for generated build files to prevent collisions, synchronizing the default app_id value with its documentation, and removing an unused parameter from the gtkSetWindowClassHint function.
Nelonn
approved these changes
May 19, 2026
Contributor
Nelonn
left a comment
There was a problem hiding this comment.
Pretty good vibecoded shit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements unified application identification mechanism across all platforms:
Changes
aui::app_info::app_idfield to AppInfoaui_app()CMake macro to auto-generate app_id from VENDOR+NAMEBenefits
✅ Unified window identification across different desktop environments
✅ Proper app-id on Wayland (instead of generic 'GTK Application')
✅ Consistent WM_CLASS on X11
✅ Custom app_id support via aui_app() CMake macro
✅ Graceful fallback if aui_app() not used
Testing