feat(config): validate new settings in atuin config set before writing them to disk - #3769
Merged
Merged
Conversation
Currently, `atuin config set` doesn't verify that the new settings can actually be deserialized, which means you can easily break your configuration in a way that `atuin config set` can't fix, because all `atuin` subcommands require a valid config. This PR validates the new settings before actually writing them to disk.
Contributor
Greptile SummaryValidates proposed
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "Remove outdated tests" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This reverts commit 1d47628.
markovejnovic
approved these changes
Jul 28, 2026
Contributor
ellie
added a commit
that referenced
this pull request
Jul 30, 2026
### Bug Fixes - *(config)* Preserve comments in `atuin config set` (#3766) - Fix atuin-search-bench/benches/search.rs (#3788) - Close OSC133 C when launching Atuin AI to prevent content erasure (#3794) ### Documentation - Clarify update check network, provide build command (#3767) - Remove old i18n docs (#3787) ### Features - *(config)* Validate new settings in `atuin config set` before writing them to disk (#3769) - Remove word with ALT-Backspace ALT-D (#2457) ### Miscellaneous Tasks - *(ci)* Fix `package` step (#3770) - Remove Store trait (#3779) - Daemon search benchmark (divan + CodSpeed) (#3763) - Run CodSpeed benchmarks on macro runners in walltime mode (#3786) - Add `OrFilter` as a replacement for `Vec`s as filter lists (#3768) - Add `atuin-domain` crate for shared domain types (#3790) - Run CodSpeed walltime benchmarks on depot-macos-26 (#3791) ### Testing - Adopt rstest across the workspace test suite (#3785) ### Daemon - Replace nucleo with frizbee, rank by match quality with frecency tiebreak (#3782)
ellie
added a commit
that referenced
this pull request
Aug 3, 2026
### Bug Fixes - *(client)* Avoid panic decoding an empty encryption key ([#3803](#3803)) - *(client)* Keep sqlx-postgres out of the client crate ([#2884](#2884)) ([#3823](#3823)) - *(config)* Preserve comments in `atuin config set` ([#3766](#3766)) - *(search)* Correct fuzzy result ranking ([#3603](#3603)) ([#3624](#3624)) - Fix atuin-search-bench/benches/search.rs ([#3788](#3788)) - Close OSC133 C when launching Atuin AI to prevent content erasure ([#3794](#3794)) - Authenticate beta release push as atuin-bot ([#3809](#3809)) - Copy vendored axoasset into docker builder stage ([#3816](#3816)) ### Documentation - Clarify update check network, provide build command ([#3767](#3767)) - Remove old i18n docs ([#3787](#3787)) - Use shell-agnostic install command in quickstart pages ([#3820](#3820)) - Document named stats periods (today/week/month/year) ([#3821](#3821)) - State minimum supported Rust version in install guide ([#3822](#3822)) - Document iTerm2 tmux popup incompatibility ([#3826](#3826)) - Clarify key binding snippets belong in shell startup file ([#3837](#3837)) - Mention RustRover in IDE integration guidance ([#3834](#3834)) ### Features - *(client)* Show intent in inspector ([#3804](#3804)) - *(client)* Enable pty-proxy via config ([#3828](#3828)) - *(config)* Validate new settings in `atuin config set` before writing them to disk ([#3769](#3769)) - *(lab)* Experimental `atuin lab share` - *(search)* Remove the "skim" engine ([#3825](#3825)) - Remove word with ALT-Backspace ALT-D ([#2457](#2457)) - Add scheduled beta release workflow ([#3805](#3805)) - Migrate TLS backend from rustls to native-tls ([#3807](#3807)) - Make `update` a real subcommand ([#3813](#3813)) - Capability negotiation protocol (client + server) ([#3797](#3797)) ### Miscellaneous Tasks - *(ci)* Fix `package` step ([#3770](#3770)) - Remove Store trait ([#3779](#3779)) - Daemon search benchmark (divan + CodSpeed) ([#3763](#3763)) - Run CodSpeed benchmarks on macro runners in walltime mode ([#3786](#3786)) - Add `OrFilter` as a replacement for `Vec`s as filter lists ([#3768](#3768)) - Add `atuin-domain` crate for shared domain types ([#3790](#3790)) - Run CodSpeed walltime benchmarks on depot-macos-26 ([#3791](#3791)) - Fix deny.toml and get it to run in CI ([#3808](#3808)) - Remove codspeed workflow ([#3812](#3812)) - Richer logging for atuin-server ([#2564](#2564)) - Hide --active sharing ([#3846](#3846)) ### Refactor - *(deps)* Bump thiserror from 2.0.18 to 2.0.19 ([#3839](#3839)) - *(deps)* Bump strum_macros from 0.27.2 to 0.28.0 ([#3841](#3841)) - *(deps)* Bump tonic-types from 0.14.5 to 0.14.6 ([#3842](#3842)) - *(deps)* Bump pulldown-cmark from 0.13.3 to 0.13.4 ([#3840](#3840)) - *(deps)* Bump itertools from 0.14.0 to 0.15.0 ([#3838](#3838)) - Adopt enum_dispatch for enum trait delegation ([#3806](#3806)) ### Testing - Adopt rstest across the workspace test suite ([#3785](#3785)) ### Daemon - Replace nucleo with frizbee, rank by match quality with frecency tiebreak ([#3782](#3782))
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
atuin config setdoesn't verify that the new settings can actually be deserialized, which means you can easily break your configuration in a way thatatuin config setcan't fix, because allatuinsubcommands require a valid config.This PR validates the new settings before actually writing them to disk.