Merged
Conversation
pguyot
reviewed
Dec 8, 2025
UncleGrumpy
force-pushed
the
improve_test_coverage
branch
from
9ff4d39 to
e56c2b3
Compare
Renames test/test_packbeam.erl -> test/packbeam_api_tests.erl to conform to standard eunit naming conventions, with the test module having the same name as the module is test with `_tests` appended to the name. This allows testing individual modules with `rebar3 eunit -m MODULE`. Add packbeam_tests.erl to test the main `packbeam` cli escript. The escript should be assembled in the `test` profile, as is done in the Makefile `etest` target, before eunit tests are run. Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
improve_test_coverage
branch
from
e56c2b3 to
c467515
Compare
pguyot
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames test/test_packbeam.erl -> test/packbeam_api_tests.erl to conform to standard eunit naming conventions, with the test module having the same name as the module with
_testsappended to the name. This allows testing individual modules withrebar3 eunit -m MODULE.Add packbeam_tests.erl to test the main
packbeamcli escript. The escript should be assembled in thetestprofile, as is done in the Makefileetesttarget, before eunit tests are run.Closes #51