Draft: Fix Settings UI#3664
Draft
luciusmagn wants to merge 80 commits into
Draft
Conversation
luciusmagn
force-pushed
the
lho-config-reloading
branch
from
8f740ff to
0462c59
Compare
Previously, the settings page would show the browser's current runtime state rather than what we just saved in auto-config.lisp. This was confusing as it made it appear that settings weren't being saved. - Add get-configured-value to read values from auto-config - Update all settings controls to check saved values first - Migrate cookie policy and zoom to use define-configuration - Make configure-slot generate define-configuration forms (just in case, I am not sure if it's needed)
luciusmagn
force-pushed
the
lho-config-reloading
branch
from
0462c59 to
bfa1fd3
Compare
jmercouris
force-pushed
the
develop
branch
2 times, most recently
from
05a53a5 to
14e3622
Compare
The buried buffer was *NOT* just accessed. Sure, it was manipulated, but not deliberately by the user.
e.g. what happens when the user selects no annotations?
Don't include periods in the title. This is how it is done in the Linux kernel.
This will be readded at some future time when it is not buggy. It is not a critical feature.
This function is too error prone. It seems a perfect candidate for post 4.0.0 refactoring.
This function is currently broken, and not critical.
This is used in many applications, notably MS Word.
Avoid collisions by previously binding it with `escape`.
This variant does _not_ currently work.
This comment adds no value.
For important modes/ modes that are enabled on certain pages, enable visibility.
The implementation was unreliable. For example, it didn't work on Wikipedia.
Make it more aesthetically pleasing
Do not fetch styles from URLs.
Additionally, remove right hand div information that wasn't particularly insightful.
It adds friction to update a distinct changelog.
Difficult to implement in the current cl-electron renderer. Additionally, it is debatable whether this method is actually effective. Finally, it is not one of the stated design goals of Nyxt to be ultra private. There exist other projects for that purpose. Nyxt is first and foremost a hackable browser that you can mold to whatever you are trying to do.
Normally we want to capture and handle input events, it is only in special cases that we do not.
Before, forwarding would not work. Additionally consider that when a command originates in pass through mode or vi insert mode, that we wish to capture any special bindings. These special bindings are typically used to disable the mode.
…avascript disabling
At the current time, these modes are not yet implemented in Electron. They may be implemented in the future. Additionally, for many of them their behavior is session wide instead of view specific. This would mean potentially proliferating several views for each buffer. This is possible, but with debatable merit. Additionally, they are removed from the manual/tutorial, which would otherwise not compile.
Previously, the settings page would show the browser's current runtime state rather than what we just saved in auto-config.lisp. This was confusing as it made it appear that settings weren't being saved. - Add get-configured-value to read values from auto-config - Update all settings controls to check saved values first - Migrate cookie policy and zoom to use define-configuration - Make configure-slot generate define-configuration forms (just in case, I am not sure if it's needed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the settings page would show the browser's current runtime
state rather than what we just saved in auto-config.lisp.
This was confusing as it made it appear that settings weren't being saved.
(just in case, I am not sure if it's needed)
Checklist:
(asdf:test-system :nyxt/<renderer>))