Always on param math changes#8
Open
atiselsts wants to merge 1 commit into
Open
Conversation
…rameters are present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When optimizing a model with always-on parameters, the parameters are included in the ranges as usual.
The problem: for example, if there are 2 always-on parameters, and the parameter selection strategry is configured as:
then only one optimization job will be created. If there are 3 always-on parameters, then with the above config no jobs will be created.
This PR changes this behavior to effectively use this dynamic parameter selection range instead: