Open
Conversation
j4r0u53k
force-pushed
the
update-rustls-0-23
branch
2 times, most recently
from
f409cc1 to
f3652b3
Compare
Updates the code to compile with newer versions of `rustls` and `rustls_pemfile`. Replaces `lazy_static` with `std::sync::LazyLock`, because `lazy_static` could not handle `async move` construct for unknown reason, and it's recommended to replace it anyways. Fixes some warnings generated by `cargo clippy`, mostly lifetime elisions. I didn't fix the warnings regarding the large size difference between variants of enums, because I wasn't sure about the correct fix. The `Poll:Ok` would probably still return the large data instead of the Box anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the code to compile with newer versions of
rustlsandrustls_pemfile.Replaces
lazy_staticwithstd::sync::LazyLock, becauselazy_staticcould not handleasync moveconstruct for unknown reason, and it's recommended to replace it anyways.Fixes some warnings generated by
cargo clippy, mostly lifetime elisions. I didn't fix the warnings regarding the large size difference between variants of enums, because I wasn't sure about the correct fix. ThePoll:Okwould probably still return the large data instead of the Box anyways.