Create basic (lower) level interface for attributes (for new feature #920)#921
Open
J007X wants to merge 13 commits intoasyml:masterfrom
Open
Create basic (lower) level interface for attributes (for new feature #920)#921J007X wants to merge 13 commits intoasyml:masterfrom
J007X wants to merge 13 commits intoasyml:masterfrom
Conversation
…s at Data_Store level (3 methods added, and corresponding unit test codes
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
==========================================
+ Coverage 81.06% 81.07% +0.01%
==========================================
Files 256 256
Lines 19858 19961 +103
==========================================
+ Hits 16097 16184 +87
- Misses 3761 3777 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…920' into create_interface_for_attributes_920
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #920.
Description of changes
(In this phase-1,) Interface methods are added to the "Data_Store" level to provide basic services that expand the previous service/methods by allowing batch-like, range selection of attributes from one or more entries (such as with one or more tid, or type-specific)
Possible influences of this PR.
This provides a new attribute based interface without the cost of packing and unpacking into classes for quicker attribute access (such as for entries). Do we need to restrict access in some ways?
Test Conducted
Corresponding unit tests are created.