-
-
Notifications
You must be signed in to change notification settings - Fork 429
Patch to solve issue #3282 (MiriadeClass) #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Many of these are already done in #3286, but that PR got stuck on upstream issues. |
|
the automatic checks are failing, but I don't see what can I do for these. |
|
@bcarry it looks like a few issues. You can follow the links on each check to see a log of the tests which should help identify the failures:
|
|
Thanks @mkelley !
|
|
Ah, it is the offline tests that are failing in |
|
Hi @mkelley
|
|
OK, just updating the files wasn't enough, but I've edited the tests and documentation to address the remaining issues. @bcarry I cannot push the changes to your branch, but I have made a pull request on it. bcarry#1 I also looked at @bsipocz 's changes in #3286, and I cherry picked some of her changes (but I didn't look into the skybot issues). |
Update documentation and tests.
|
OK, we're getting closer. The devdeps job's failure is unrelated, but I'm afraid the rest still have some relevance (besides the RTD failure which may be resolved with a rebase) |
IMCCE base URL was changed from
http://vo.imcce.frto
https://ssp.imcce.frThe columns from the Miriade/ephemcc service have changed on the new server, and the documentation adapted