Skip to content

CompatHelper: bump compat for Optim to 2, (keep existing compat)#534

Open
github-actions[bot] wants to merge 2 commits intomasterfrom
compathelper/new_version/2026-01-10-00-14-19-991-03518477868
Open

CompatHelper: bump compat for Optim to 2, (keep existing compat)#534
github-actions[bot] wants to merge 2 commits intomasterfrom
compathelper/new_version/2026-01-10-00-14-19-991-03518477868

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This pull request changes the compat entry for the Optim package from 1.8 - 1.13 to 1.8 - 1.13, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Feb 1, 2026

Benchmark Results (Julia v1)

Time benchmarks
master a3113db... master / a3113db...
search/multithreading 15.3 ± 0.35 s 15.4 ± 0.3 s 0.993 ± 0.03
search/serial 33.4 ± 0.081 s 33.3 ± 0.33 s 1 ± 0.01
utils/best_of_sample 2.02 ± 0.61 μs 1.8 ± 0.53 μs 1.12 ± 0.47
utils/check_constraints_x10 16.7 ± 4.2 μs 16.8 ± 4.2 μs 0.996 ± 0.35
utils/compute_complexity_x10/Float64 2.15 ± 0.09 μs 2.18 ± 0.09 μs 0.99 ± 0.058
utils/compute_complexity_x10/Int64 2.11 ± 0.09 μs 2.04 ± 0.089 μs 1.03 ± 0.063
utils/compute_complexity_x10/nothing 1.52 ± 0.08 μs 1.5 ± 0.089 μs 1.01 ± 0.08
utils/insert_random_op_x10 5.17 ± 1.7 μs 5.34 ± 1.7 μs 0.968 ± 0.44
utils/next_generation_x100 0.434 ± 0.021 ms 0.444 ± 0.022 ms 0.979 ± 0.068
utils/optimize_constants_x10 0.0371 ± 0.0079 s 0.0368 ± 0.0081 s 1.01 ± 0.31
utils/randomly_rotate_tree_x10 7.86 ± 0.93 μs 8 ± 0.93 μs 0.982 ± 0.16
time_to_load 2.62 ± 0.026 s 2.66 ± 0.034 s 0.983 ± 0.016
Memory benchmarks
master a3113db... master / a3113db...
search/multithreading 0.205 G allocs: 53.3 GB 0.206 G allocs: 53 GB 1.01
search/serial 0.207 G allocs: 53.8 GB 0.207 G allocs: 53.8 GB 1
utils/best_of_sample 0.038 k allocs: 3.25 kB 0.038 k allocs: 3.25 kB 1
utils/check_constraints_x10 0.034 k allocs: 0.875 kB 0.034 k allocs: 0.875 kB 1
utils/compute_complexity_x10/Float64 0 allocs: 0 B 0 allocs: 0 B
utils/compute_complexity_x10/Int64 0 allocs: 0 B 0 allocs: 0 B
utils/compute_complexity_x10/nothing 0 allocs: 0 B 0 allocs: 0 B
utils/insert_random_op_x10 0.04 k allocs: 1.56 kB 0.046 k allocs: 1.94 kB 0.806
utils/next_generation_x100 4.62 k allocs: 0.275 MB 4.62 k allocs: 0.276 MB 0.999
utils/optimize_constants_x10 21.5 k allocs: 21.3 MB 25 k allocs: 25.7 MB 0.828
utils/randomly_rotate_tree_x10 0.042 k allocs: 1.34 kB 0.042 k allocs: 1.34 kB 1
time_to_load 0.145 k allocs: 11 kB 0.145 k allocs: 11 kB 1

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (5b5a5a3) to head (a3113db).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   94.97%   95.00%   +0.02%     
==========================================
  Files          42       42              
  Lines        3880     3880              
==========================================
+ Hits         3685     3686       +1     
+ Misses        195      194       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SebastianM-C
Copy link
Copy Markdown

Hi! I saw that you are doing some backports for v1, Is this PR something that could also be backported to v1?

@MilesCranmer
Copy link
Copy Markdown
Collaborator

I think so

@MilesCranmerBot can you backport to release-v1 please

@MilesCranmerBot
Copy link
Copy Markdown
Contributor

Backport opened: #558 (targets release-v1).

@MilesCranmer
Copy link
Copy Markdown
Collaborator

@SebastianM-C actually I think this will require a bit more work b/c of SymbolicML/DynamicExpressions.jl#156 not being merged yet. It's tricky because the NLSolversBase API changed so much. Not sure when it will be done. How urgent is it and might you be willing to assist at all if very urgent? It's term time in cambridge so very busy unfortunately

@SebastianM-C
Copy link
Copy Markdown

I'll take a look there and see what I can do. Thanks for mentioning that PR, I didn't catch that.

@MilesCranmer
Copy link
Copy Markdown
Collaborator

@MilesCranmerBot in about 30min (after new DE.jl version is registered) can you make a fork of this, resolve conflicts w.r.t master, and then submit a PR. Should set a timer for 30min (from this comment's time) so that the new version actually gets registered first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants