You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request changes the compat entry for the Optim package from 1.8 - 1.13 to 1.8 - 1.13, 2.
This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
@SebastianM-C actually I think this will require a bit more work b/c of SymbolicML/DynamicExpressions.jl#156 not being merged yet. It's tricky because the NLSolversBase API changed so much. Not sure when it will be done. How urgent is it and might you be willing to assist at all if very urgent? It's term time in cambridge so very busy unfortunately
@MilesCranmerBot in about 30min (after new DE.jl version is registered) can you make a fork of this, resolve conflicts w.r.t master, and then submit a PR. Should set a timer for 30min (from this comment's time) so that the new version actually gets registered first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Optimpackage from1.8 - 1.13to1.8 - 1.13, 2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.