Restore Trapani argument check and use only static args#363
Open
matt-graham wants to merge 1 commit intomainfrom
Open
Restore Trapani argument check and use only static args#363matt-graham wants to merge 1 commit intomainfrom
matt-graham wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
==========================================
- Coverage 96.14% 96.12% -0.03%
==========================================
Files 32 32
Lines 3452 3456 +4
==========================================
+ Hits 3319 3322 +3
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
willGraham01
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65 and #273
I am not entirely sure why the check functions body was originally commented out but I suspect it was related to the checks not working within traced JAX functions as
elargument would be an abstract tracer rather than a concrete value at tracing. This PR restores most of the checks beyond the assertion that0 < el < Lon the assumption that some checks are better than none and the assertions in terms ofLand shape ofdlshould work with JAX tracing as these will both be known statically at trace time. Also replaced the previous use of now removed logging module to flag warning around largeLwith using thewarnfunction from the built inwarningsmodule.