[airflow] Add AIR331 rule for airflow.traces module removed in Airflow 3.2#23914
[airflow] Add AIR331 rule for airflow.traces module removed in Airflow 3.2#23914dstandish wants to merge 1 commit intoastral-sh:mainfrom
AIR331 rule for airflow.traces module removed in Airflow 3.2#23914Conversation
…rflow 3.2 The `airflow.traces` module was removed in Airflow 3.2. Add a new lint rule to flag imports from this module so users can identify and remove them before upgrading. Made-with: Cursor
|
Thank you! I'm happy to give this a review, but I like to check in with @Lee-W first :) |
|
|
Sure, will do it early next week. We're establishing the process how we contribute to ruff from airflow community. But Daniel's PR is most likely correct haha. Will take a deeper look 👀 |
All credit goes to claude |
|
@Lee-W if we are also removing airflow.metrics and airflow.stats in 3.2, would it make sense to add these to the same ruff rule? |
yep, we group logics with the same purpose into one rule |
Hi -- I am an airflow contributor. A real human one.
I want to add this rule to help identify if an airflow user is importing from the traces package (which we are removing in 3.2).
Thanks for your review.
Summary
AIR331lint rule that flags imports from theairflow.tracesmodule, which was removed in Airflow 3.2airflow.traces.otel_tracer,airflow.traces.tracer,airflow.traces.utils, and all submodule membersTest plan
AIR331_names.pywith positive and negative cases