Skip to content

wallet grpc stubs - #144

Open
biryukovmaxim wants to merge 102 commits into
aspectron:sigmafrom
biryukovmaxim:grpc-wallet
Open

wallet grpc stubs#144
biryukovmaxim wants to merge 102 commits into
aspectron:sigmafrom
biryukovmaxim:grpc-wallet

Conversation

@biryukovmaxim

Copy link
Copy Markdown
Collaborator

No description provided.

aspect and others added 30 commits September 2, 2024 16:02
Comment thread wallet/grpc/server/src/lib.rs Outdated
}

async fn send(&self, _request: Request<SendRequest>) -> Result<Response<SendResponse>, Status> {
let response = SendResponse { tx_i_ds: vec![], signed_transactions: vec![] };

@michaelsutton michaelsutton Jan 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tx_i_ds is interesting. Might be worth renaming in the proto to txIds, txId so that the rust naming transform makes it tx_ids, tx_id

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed 39b8738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants