Implement skill validation and enhance skill management#2
Open
yumosx wants to merge 1 commit intoaspasskiy:mainfrom
Open
Implement skill validation and enhance skill management#2yumosx wants to merge 1 commit intoaspasskiy:mainfrom
yumosx wants to merge 1 commit intoaspasskiy:mainfrom
Conversation
- Added a new `Validate` method to the `Skill` struct to enforce rules on name and description, improving data integrity. - Introduced constants for skill file naming and length restrictions to standardize skill attributes. - Updated `CreateSkill` and `UpdateSkill` methods in `LocalStore` to include validation checks, ensuring skills meet defined criteria before creation or updates. - Enhanced skill loading logic to skip invalid skills and log warnings, improving robustness in skill management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validatemethod to theSkillstruct to enforce rules on name and description, improving data integrity.CreateSkillandUpdateSkillmethods inLocalStoreto include validation checks, ensuring skills meet defined criteria before creation or updates.