Fix askama template when called from within a macro in a different crate#728
Merged
GuillaumeGomez merged 3 commits intoaskama-rs:mainfrom Apr 12, 2026
Conversation
70c5e07 to
556018a
Compare
556018a to
3733a9d
Compare
Contributor
|
I can confirm that the latest Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #706.
This is a "two parts" problem:
Span::call_sitegives the actual file where the macro is called, so not where the macro containing is called but where it's defined. Super weird but nothing we can do from our side.include_bytes!statements we generate (sorustcrebuilds when needed) as much as possible.So the fix here is: "if this doesn't seem to come from the same crate, then we provide the absolute path we have instead of trying to make it nicer".
If you could confirm it fixed the problem for you @cipriancraciun, it'd be super appreciated. :)